feat(bundler): consider extensions defined in main.wxs. #14570
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Package Changes Through a88fbe5There are 1 changes which include tauri-bundler with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
previously approved these changes
Dec 1, 2025
Contributor
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
Thanks! Do you mind also adding a change file?
https://github.com/tauri-apps/tauri/blob/dev/.changes/README.md
And just a question, this is for custom templates right (bundle > windows > wix > template)?
| let fragment_content = fs::read_to_string(&fragment_path)?; | ||
| let fragment_handlebars = Handlebars::new(); | ||
| let fragment = fragment_handlebars.render_template(&fragment_content, &data)?; | ||
| let input_paths = std::iter::once(output_path.join(PathBuf::from("main.wxs"))) |
Contributor
There was a problem hiding this comment.
A nitpick, we can reuse main_wxs_path here
Author
There was a problem hiding this comment.
Thanks a lot! Nitpick is applied.
chfaft
force-pushed
the
feat/ext-support-in-main-wxs
branch
from
a16e9d4 to
2dbe066
Compare
chfaft
force-pushed
the
feat/ext-support-in-main-wxs
branch
from
dcf7564 to
2855f13
Compare
chore(bundler): avoid clone and use reference. Co-authored-by: Tony <[email protected]>
chore(bundler): reclassify changes. Co-authored-by: Tony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends extension support for the Tauri installer by considering not only
fragment_pathsfor extension inclusion, but also the mainmain.wxsconfiguration file itself.Previously, the integration of extensions was limited to fragments, making it harder to manage installer customization in a centralized location.
What’s changed
fragment_pathsand the mainmain.wxsfile are now recognized and included during the installer build process.Why
This change allows developers to manage all necessary installer extensions directly in fragments as well as in template, enabling more flexible and maintainable Windows installer configurations and reducing the need to split extension logic unnecessarily.